Improve setup experience with example values & readme tips #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybaumgar
approved these changes
Aug 27, 2023
|
@WillNilges this is going to conflict with your readme changes in #27. Do you want me to wait and fix the conflicts on my side or are you okay if I merge now? |
|
go for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a workflow/readme PR that makes it easier to get started with the project. I find even when working with experienced developers, having comprehensive & unambiguous setup instructions dramatically decreases the burden when onboarding new folks
I made a guess about the
DB_NAMEvalue, but I'm guessing it doesn't matter as long as everyone reads from the same.envfile. Roast me if it needs to be something specific